Skip to content

Fix login dialog modality so prompts show while Settings is open#22

Merged
Idddd merged 5 commits into
mainfrom
codex/fix-login-popup-not-displaying
May 19, 2026
Merged

Fix login dialog modality so prompts show while Settings is open#22
Idddd merged 5 commits into
mainfrom
codex/fix-login-popup-not-displaying

Conversation

@Idddd
Copy link
Copy Markdown
Collaborator

@Idddd Idddd commented May 19, 2026

Motivation

  • Fix the issue where the LLM login prompt and its success/error notifications are blocked by the Settings dialog and only appear after Settings is closed, by ensuring dialogs shown from background threads are not constrained by the current modal context.

Description

  • Added ModalityState import and changed invokeLater calls to use invokeLater(..., ModalityState.any()) for login success and error notifications in LlmAuthSessionService.
  • Replaced app.invokeAndWait(showDialog) with app.invokeAndWait(showDialog, ModalityState.any()) so the credential dialog can appear immediately when triggered from a background thread.
  • Changes are contained in plugin-idea/src/main/kotlin/org/openprojectx/ai/plugin/LlmAuthSessionService.kt.

Testing

  • Attempted to compile the module with ./gradlew :plugin-idea:compileKotlin, but compilation could not complete in this environment due to a missing Gradle wrapper runtime class org.gradle.wrapper.GradleWrapperMain (so build verification is pending).
  • No additional automated tests were run in this environment.

Codex Task

@Idddd Idddd merged commit dfe916f into main May 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant